Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable statistics view if no deploys are present #978

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@DazWorrall
Copy link
Member

DazWorrall commented Jan 8, 2020

Fixes: undefined method zero? for nil:NilClass

gems/activesupport-6.0.2.1/lib/active_support/duration.rb:212:in `block in initialize': undefined method `zero?' for nil:NilClass (ActionView::Template::Error)
    from gems/activesupport-6.0.2.1/lib/active_support/duration.rb:212:in `reject!'
    from gems/activesupport-6.0.2.1/lib/active_support/duration.rb:212:in `initialize'
    from bundler/gems/shipit-engine-767318bc03a5models/shipit/duration.rb:38:in `initialize'
    from bundler/gems/shipit-engine-767318bc03a5views/shipit/stacks/statistics.html.erb:36:in `new'
@DazWorrall DazWorrall requested review from byroot and casperisfine Jan 8, 2020
@DazWorrall DazWorrall merged commit 82d2452 into master Jan 8, 2020
3 checks passed
3 checks passed
CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@DazWorrall DazWorrall deleted the stats-handle-no-deploys branch Jan 8, 2020
@shopify-shipit shopify-shipit bot deployed to rubygems Jan 8, 2020 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.