Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CommitDeploymentStatus GitHub creation job #983

Closed
wants to merge 1 commit into from

Conversation

@DazWorrall
Copy link
Member

DazWorrall commented Jan 10, 2020

I'm debugging a race where the initial status is not created on GitHub after the deployment is created. Using commit_deployment as the argument here looks like a typo to me, surely it should be itself. The warning log is for further debugging if I've got this wrong.

Should I deploy our instance from this branch and 馃帺 before merging?

@DazWorrall DazWorrall requested a review from casperisfine Jan 10, 2020
@DazWorrall

This comment has been minimized.

Copy link
Member Author

DazWorrall commented Jan 10, 2020

Actually I kinda see what this was trying to do here. Not sure how I've broken it yet 馃

@DazWorrall

This comment has been minimized.

Copy link
Member Author

DazWorrall commented Jan 10, 2020

Disregard, I found the real issue in #984.

@DazWorrall DazWorrall closed this Jan 10, 2020
@DazWorrall DazWorrall deleted the status-create-fix branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.