Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a GitHub deployment status for the running state #984

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@DazWorrall
Copy link
Member

DazWorrall commented Jan 10, 2020

We intend to create a deployment status immediately after creating the deployment, however when #982 moved the deployment creation to a job a delay was created. Now the initial status may be created when the job is already running, and we did not have a corresponding status for that state.

I have tophatted locally:

Screenshot 2020-01-10 at 13 31 56

@DazWorrall DazWorrall requested review from JackTLi and casperisfine Jan 10, 2020
@DazWorrall DazWorrall merged commit 9261062 into master Jan 10, 2020
3 checks passed
3 checks passed
CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@DazWorrall DazWorrall deleted the running-deployment-statuses branch Jan 10, 2020
@shopify-shipit shopify-shipit bot deployed to rubygems Jan 10, 2020 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.