Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log deployment status creation #986

Merged
merged 1 commit into from Jan 10, 2020
Merged

Log deployment status creation #986

merged 1 commit into from Jan 10, 2020

Conversation

@DazWorrall
Copy link
Member

DazWorrall commented Jan 10, 2020

#982 moved deployment and status creation async, and has created some racey issues. I'm trying to debug some instances where the final status is not created and reported, and need some more clues.

@DazWorrall DazWorrall requested review from JackTLi and casperisfine Jan 10, 2020
@DazWorrall DazWorrall merged commit 26320e3 into master Jan 10, 2020
3 checks passed
3 checks passed
CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@shopify-shipit shopify-shipit bot requested a deployment to rubygems Jan 10, 2020 In progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.