Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch 100 commit statuses at a time #989

Merged
merged 1 commit into from Jan 13, 2020
Merged

Fetch 100 commit statuses at a time #989

merged 1 commit into from Jan 13, 2020

Conversation

@DazWorrall
Copy link
Member

DazWorrall commented Jan 13, 2020

Core deploys are getting stuck because Shipit thinks some statuses are missing, despite the statuses on GitHub being present and passing. After some debugging it seems that this is a [lack of] pagination problem - a core commit has something like ~50 status records now, and the default fetch size is 30. This is a hotfix to unblock deploys, pending some actual pagination support.

@DazWorrall DazWorrall requested review from casperisfine and Shopify/pipeline Jan 13, 2020
Copy link
Contributor

ajshepley left a comment

~50+ statuses? Wow.

We should add a test for this, but it's a live issue so it can wait for a future PR.

@DazWorrall DazWorrall force-pushed the DazWorrall-patch-1 branch from e5280cf to d37c0b4 Jan 13, 2020
@DazWorrall

This comment has been minimized.

Copy link
Member Author

DazWorrall commented Jan 13, 2020

~50+ statuses? Wow

They aren't unique contexts, you create a new status record and the state of the latest one wins for any given context. So a typical context has at least 2 status records (pending -> success).

@ajshepley

This comment has been minimized.

Copy link
Contributor

ajshepley commented Jan 13, 2020

Ah, I see. That makes more sense.

@DazWorrall DazWorrall merged commit 1c5ec45 into master Jan 13, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@DazWorrall DazWorrall deleted the DazWorrall-patch-1 branch Jan 13, 2020
@shopify-shipit shopify-shipit bot requested a deployment to rubygems Jan 13, 2020 In progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.