Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitHub actions for CI #990

Merged
merged 1 commit into from Jan 16, 2020
Merged

Setup GitHub actions for CI #990

merged 1 commit into from Jan 16, 2020

Conversation

@DazWorrall
Copy link
Member

DazWorrall commented Jan 13, 2020

Motivated by the irritatingly long wait for Travis agents earlier, this replicates the existing CI setup on GitHub actions.

On the plus side, these jobs generally start much quicker than on Travis, and are well integrated into GitHub. On the down side, Actions themselves are still reasonably new and are changing rapidly, and annoyingly they do not support Yaml anchors/aliases, so this config file is enormous and full of duplicated things.

I suggest we run this alongside Travis for a while and see how we fare.

@DazWorrall DazWorrall requested review from wvanbergen and casperisfine Jan 13, 2020
- name: rubocop
run: |
sudo apt-get -yqq install libpq-dev libsqlite3-dev libmysqlclient-dev
gem install bundler:1.17.3

This comment has been minimized.

Copy link
@wvanbergen

wvanbergen Jan 13, 2020

Member

should be update to bundler 2?

This comment has been minimized.

Copy link
@DazWorrall

DazWorrall Jan 16, 2020

Author Member

Probably, I will look at that separately though.

${{ runner.os }}-gems-
- name: rubocop
run: |
sudo apt-get -yqq install libpq-dev libsqlite3-dev libmysqlclient-dev

This comment has been minimized.

Copy link
@wvanbergen

wvanbergen Jan 13, 2020

Member

I wonder whether we can get away with not installing those, and only installing a partial bundler for Rubocop.

Not sure if the time to optimize this is worth it though. Feel free to leave it as is.

Copy link
Member

wvanbergen left a comment

LGTM with some minor comments.

Copy link
Contributor

casperisfine left a comment

I'm fine with experimenting.

@@ -0,0 +1,165 @@
name: CI

on: [push, pull_request]

This comment has been minimized.

Copy link
@casperisfine

casperisfine Jan 14, 2020

Contributor

Do we need both? I don't know GH actions well, but all statuses seem duplicated on this PR.

This comment has been minimized.

Copy link
@DazWorrall

DazWorrall Jan 16, 2020

Author Member

pull_request is required to build PRs from forks I think, I agree the duplicated statuses are annoying - afaict there's no option to squash these :/

@DazWorrall DazWorrall merged commit b872c65 into master Jan 16, 2020
17 checks passed
17 checks passed
Lint Ruby
Details
Lint Ruby
Details
Tests with Postgres (2.5.x)
Details
Tests with Postgres (2.5.x)
Details
Tests with Postgres (2.6.x)
Details
Tests with Postgres (2.6.x)
Details
Tests with MySQL (2.5.x)
Details
Tests with MySQL (2.5.x)
Details
Tests with MySQL (2.6.x)
Details
Tests with MySQL (2.6.x)
Details
Tests with SQLite3 (2.5.x)
Details
Tests with SQLite3 (2.5.x)
Details
Tests with SQLite3 (2.6.x)
Details
Tests with SQLite3 (2.6.x)
Details
CLA Contributor License Agreement (CLA) status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@DazWorrall DazWorrall deleted the gh-actions-ci branch Jan 16, 2020
@shopify-shipit shopify-shipit bot deployed to rubygems Jan 16, 2020 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.