From 7ed9750603ffd94bce55c9d74ecdad34d565dd00 Mon Sep 17 00:00:00 2001 From: Ignacio Chiazzo Date: Mon, 23 Dec 2019 11:50:14 -0300 Subject: [PATCH 1/2] Release 2020-01 REST ADMIN API VERSION --- test/api_version_test.rb | 11 ++++++----- test/fixtures/apis.json | 14 ++++++++++---- test/meta_test.rb | 24 +++++++++++++++--------- 3 files changed, 31 insertions(+), 18 deletions(-) diff --git a/test/api_version_test.rb b/test/api_version_test.rb index 8493fe7bd..7d53fbd84 100644 --- a/test/api_version_test.rb +++ b/test/api_version_test.rb @@ -22,15 +22,15 @@ class ApiVersionTest < Test::Unit::TestCase test "find_version removes unverified versions from version set if mode is set to :raise_on_unknown" do ShopifyAPI::ApiVersion.version_lookup_mode = :define_on_unknown assert ShopifyAPI::ApiVersion.versions.values.all?(&:verified?) - assert_equal 5, ShopifyAPI::ApiVersion.versions.size + assert_equal 6, ShopifyAPI::ApiVersion.versions.size ShopifyAPI::ApiVersion.find_version('2019-30') refute ShopifyAPI::ApiVersion.versions.values.all?(&:verified?) - assert_equal 6, ShopifyAPI::ApiVersion.versions.size + assert_equal 7, ShopifyAPI::ApiVersion.versions.size ShopifyAPI::ApiVersion.version_lookup_mode = :raise_on_unknown assert ShopifyAPI::ApiVersion.versions.values.all?(&:verified?) - assert_equal 5, ShopifyAPI::ApiVersion.versions.size + assert_equal 6, ShopifyAPI::ApiVersion.versions.size end test "find_version does not raise when coercing a string if no versions are defined when version_lookup_mode is :define_on_unknown" do @@ -101,8 +101,9 @@ class ApiVersionTest < Test::Unit::TestCase { "2019-01" => ShopifyAPI::ApiVersion.new(handle: '2019-01', supported: true, latest_supported: false), "2019-04" => ShopifyAPI::ApiVersion.new(handle: '2019-04', supported: true, latest_supported: false), - "2019-07" => ShopifyAPI::ApiVersion.new(handle: '2019-07', supported: true, latest_supported: true), + "2019-07" => ShopifyAPI::ApiVersion.new(handle: '2019-07', supported: true, latest_supported: false), "2019-10" => ShopifyAPI::ApiVersion.new(handle: '2019-10', supported: false, latest_supported: false), + "2020-01" => ShopifyAPI::ApiVersion.new(handle: '2020-01', supported: false, latest_supported: true), "unstable" => ShopifyAPI::ApiVersion.new(handle: 'unstable', supported: false, latest_supported: false), } ) @@ -114,7 +115,7 @@ class ApiVersionTest < Test::Unit::TestCase ) assert_equal( - ShopifyAPI::ApiVersion.new(handle: '2019-07'), + ShopifyAPI::ApiVersion.new(handle: '2020-01'), ShopifyAPI::ApiVersion.latest_stable_version ) end diff --git a/test/fixtures/apis.json b/test/fixtures/apis.json index 346cd48c6..62ac781a6 100644 --- a/test/fixtures/apis.json +++ b/test/fixtures/apis.json @@ -14,15 +14,21 @@ }, { "handle": "2019-07", - "latest_supported": true, - "display_name": "2019-07 (Latest)", + "latest_supported": false, + "display_name": "2019-07", "supported": true }, { "handle": "2019-10", "latest_supported": false, - "display_name": "2019-10 (Release candidate)", - "supported": false + "display_name": "2019-10", + "supported": true + }, + { + "handle": "2020-01", + "latest_supported": true, + "display_name": "2020-01 (Latest)", + "supported": true }, { "handle": "unstable", diff --git a/test/meta_test.rb b/test/meta_test.rb index 57e412e55..7cecc332a 100644 --- a/test/meta_test.rb +++ b/test/meta_test.rb @@ -8,32 +8,38 @@ class ApiVersionTest < Test::Unit::TestCase "handle": "2019-01", "display_name": "2019-01", "supported": true, - "latest_supported": false, + "latest_supported": false }, { "handle": "2019-04", "latest_supported": false, "display_name": "2019-04", - "supported": true, + "supported": true }, { "handle": "2019-07", - "latest_supported": true, - "display_name": "2019-07 (Latest)", - "supported": true, + "latest_supported": false, + "display_name": "2019-07", + "supported": true }, { "handle": "2019-10", "latest_supported": false, - "display_name": "2019-10 (Release candidate)", - "supported": false, + "display_name": "2019-10", + "supported": true + }, + { + "handle": "2020-01", + "latest_supported": true, + "display_name": "2020-01 (Latest)", + "supported": true }, { "handle": "unstable", "latest_supported": false, "display_name": "unstable", - "supported": false, - }, + "supported": false + } ].to_json From 47ea7edded575969a1ef14bb2b5f1b39bc07b802 Mon Sep 17 00:00:00 2001 From: Ignacio Chiazzo Date: Mon, 23 Dec 2019 13:09:18 -0300 Subject: [PATCH 2/2] Update api_version.json test --- test/fixtures/api_versions.json | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/test/fixtures/api_versions.json b/test/fixtures/api_versions.json index ff95cc4fa..c79bd0800 100644 --- a/test/fixtures/api_versions.json +++ b/test/fixtures/api_versions.json @@ -7,26 +7,32 @@ }, { "handle": "2019-04", + "latest_supported": false, "display_name": "2019-04", - "supported": true, - "latest_supported": false + "supported": true }, { "handle": "2019-07", - "display_name": "2019-07 (Latest)", - "supported": true, - "latest_supported": true + "latest_supported": false, + "display_name": "2019-07", + "supported": true }, { "handle": "2019-10", - "display_name": "2019-10 (Release candidate)", - "supported": false, - "latest_supported": false + "latest_supported": false, + "display_name": "2019-10", + "supported": true + }, + { + "handle": "2020-01", + "latest_supported": true, + "display_name": "2020-01 (Latest)", + "supported": true }, { "handle": "unstable", + "latest_supported": false, "display_name": "unstable", - "supported": false, - "latest_supported": false + "supported": false } ]