Navigation Menu

Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Use draft PR instead of WIP indicator #969

Merged
merged 1 commit into from Nov 6, 2020
Merged

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Nov 6, 2020

Using a draft PR better conveys the intention of something being a work in progress, and protects against accidental merges.

Using a draft PR better conveys the intention of something being a work in progress, and protects against accidental merges.
@andyw8 andyw8 requested a review from a team as a code owner November 6, 2020 15:13
@carmelal
Copy link
Contributor

carmelal commented Nov 6, 2020

Would both be overkill? [WIP] is easier to see, but the draft status stops accidental merging/reviews.

@paulomarg
Copy link
Contributor

Would both be overkill? [WIP] is easier to see, but the draft status stops accidental merging/reviews.

I'd personally see it as overkill. I see [WIP] as do not review yet, which is exactly what drafts are meant to be, so having both feels slightly redundant.

I'm not sure if the green vs gray icons are tricky for colourblind people, though, which is the only reason I can see for [WIP] or both.

@andyw8
Copy link
Contributor Author

andyw8 commented Nov 6, 2020

I'm not sure if the green vs gray icons are tricky for colourblind people, though, which is the only reason I can see for [WIP] or both.

The colours aren't great for me but it says "Draft" in the description.

@andyw8 andyw8 merged commit 66c5281 into master Nov 6, 2020
@andyw8 andyw8 deleted the andyw8/draft-pr-not-wip branch November 6, 2020 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants