match graphql dep to @shopify/api-codegen-preset #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/shop/issues-shopifyvm/issues/727.
I documented my investigations in this comment, but TL;DR:
graphql@16.12.0.@shopify/shopify_function) has a locked dependency tographql@16.11.0.pnpmloads both, but graphql-js has some guardrails where it errors out when it detects multiple versions.This PR fixes this by unlocking our graphql dep, and matching it to what gets pulled into the react router app via @shopify/api-codegen-preset.
There's still the potential for things to get out of sync in the future should a different version of
graphqlget pulled into our templates, but this addresses the errors encountered in today's out-of-the-box flow.How to 🎩
pnpmmanaged shopify app, using the react router template.Cannot use GraphQLScalarType "Boolean" from another module or realm.@shopify/shopify_function