Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle HTTP instead of plain CURL #5

Open
sv3tli0 opened this issue May 13, 2017 · 12 comments

Comments

Projects
None yet
6 participants
@sv3tli0
Copy link

commented May 13, 2017

It's really good that you are writing PHP API library for Shopify.

I want to suggest to you to use Guzzle HTTP which is advanced HTTP request library instead of reinventing the wheel with custom CURL classes and etc.

@joshubrown

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2017

Hey @sv3tli0 - thanks for the feedback :) We'd like to support Guzzle alongside cURL so you can choose either one. I'll leave this issue open until we add Guzzle as an option.

@sv3tli0

This comment has been minimized.

Copy link
Author

commented Jun 7, 2017

Guzzle is initially based on curl, that is why I recommend it :)

@rodolfobandeira

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

Hi @sv3tli0,

I asked myself the same question when I first saw this repository. If we check other famous companies Amazon, Google and Facebook, we'll see that they're all using Guzzle. Unfortunately looks like Shopify doesn't have a dedicated PHP team to help out so I would say that it's up to the community to take some initiative. Using guzzle would require a big chunk of refactoring here. The good point is that the API is still small so if @joshubrown gives the thumbs up for this action, it would be easier to work on this now before the API gets more code.

@joshubrown Sorry to disagree but I don't think that providing both Guzzle and non-Guzzle would work. I know that you're pretty busy with Webinars and I'm not sure if you guys have more hands to work on this API there at Shopify.

I'm pretty busy as well but I'd love to help out on this refactoring to use Guzzle instead.

@ferrazzuk

This comment has been minimized.

Copy link

commented Jun 8, 2017

@rodolfobandeira if @joshubrown agree's I'll be willing to help as long Shopify supports the maintenance of this.

@yurivecchi

This comment has been minimized.

Copy link

commented Jun 15, 2017

I gonna help too

@rodolfobandeira

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2017

@joshubrown

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2017

OK, you are convincing me :) Thanks for the PR @rodolfobandeira! I will review it this weekend.

@slince

This comment has been minimized.

Copy link

commented Nov 18, 2017

up

@slince

This comment has been minimized.

Copy link

commented Nov 24, 2017

@joshubrown Hi, Will the pr will be merged?

@rodolfobandeira

This comment has been minimized.

Copy link
Contributor

commented Nov 24, 2017

Hey @joshubrown, Looks like you're not working at Shopify anymore? Are you still maintaining this repository?

Hey @slince, The PR I made is just a kick start on using Guzzle. A good amount of code is necessary to replace the existing classes to use Guzzle instead of raw CURL. Kind of involves some re-design and architecture in order to do that. I've been trying to find some spare time to help out but it's hard. Maybe I can get back to this in December.

@slince

This comment has been minimized.

Copy link

commented Nov 29, 2017

@rodolfobandeira @joshubrown @yurivecchi @ALL

Hi i have created a new repo https://github.com/slince/shopify-api-php, Hope it is more reliable than this repo; 😋

@joshubrown

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

Hi @rodolfobandeira, that's correct I'm no longer at Shopify. I did chat with them about the repo and there should be someone new taking a look here soon. Thank you @slince for your interest and contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.