update default to https #115

Merged
merged 3 commits into from Feb 3, 2014

Conversation

Projects
None yet
3 participants
@kevinhughes27
Contributor

kevinhughes27 commented Feb 3, 2014

pretty straightforward I just changed over all the test cases to use https nothing needs to change in the code but if we want people to use https then we should use it in the tests.

@maartenvg @phoet

@kevinhughes27 kevinhughes27 referenced this pull request in Shopify/shopify_python_api Feb 3, 2014

Merged

use https in tests #43

@maartenvg

This comment has been minimized.

Show comment Hide comment
@maartenvg

maartenvg Feb 3, 2014

Member

Maybe at the same time change localhost for this-is-my-test-show.myshopify.com to be even closer to production.

Member

maartenvg commented Feb 3, 2014

Maybe at the same time change localhost for this-is-my-test-show.myshopify.com to be even closer to production.

@kevinhughes27

This comment has been minimized.

Show comment Hide comment
@kevinhughes27

kevinhughes27 Feb 3, 2014

Contributor

👍

Contributor

kevinhughes27 commented Feb 3, 2014

👍

test/detailed_log_subscriber_test.rb
@@ -26,7 +26,7 @@ def set_logger(logger)
ShopifyAPI::Page.find(1)
assert_equal 4, @logger.logged(:info).size
- assert_equal "GET http://localhost:80/admin/pages/1.json", @logger.logged(:info)[0]
+ assert_equal "GET https://this-is-my-test-show.myshopify.com:443/admin/pages/1.json", @logger.logged(:info)[0]

This comment has been minimized.

Show comment Hide comment
@phoet

phoet Feb 3, 2014

Contributor

:whitespace_nazi:

@phoet

phoet Feb 3, 2014

Contributor

:whitespace_nazi:

kevinhughes27 added a commit that referenced this pull request Feb 3, 2014

@kevinhughes27 kevinhughes27 merged commit 8f3c9b7 into master Feb 3, 2014

@kevinhughes27 kevinhughes27 deleted the https_default branch Feb 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment