adding usage charge resource #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,5 +19,9 @@ def cancel | |||
| def activate | |||
| load_attributes_from_response(post(:activate)) | |||
| end | |||
|
|
|||
| def customize(capped_amount) | |||
There was a problem hiding this comment.
Should this be a hash so its customize(capped_amount: 10) ?
ch33sybr3ad
force-pushed
the
usage_charge_resource
branch
from
6ef015e
to
fc951fe
Compare
ch33sybr3ad
force-pushed
the
usage_charge_resource
branch
from
fc951fe
to
ef67b98
Compare
ch33sybr3ad
force-pushed
the
usage_charge_resource
branch
from
f0787a5
to
49dad78
Compare
ch33sybr3ad
force-pushed
the
usage_charge_resource
branch
from
49dad78
to
d9af79a
Compare
|
@Shopify/finance 👀 please Need to merge, so I can write some api unit tests for usage charges within shopify to help @joshubrown with documentation |
| class << self | ||
| def index(recurring_application_charge_id) | ||
| UsageCharge.find(:all, :params => { :recurring_application_charge_id => recurring_application_charge_id }) | ||
| rescue ActiveResource::ForbiddenAccess |
There was a problem hiding this comment.
why are you catching this - if you let it bubble up doesn't the client get a 403 and wouldn't that be preferred?
There was a problem hiding this comment.
Sorry - this is the client API already - this is the 403 coming back from the server
ch33sybr3ad
force-pushed
the
usage_charge_resource
branch
from
d9af79a
to
de89c06
Compare
|
|
||
| usage_charges = ShopifyAPI::UsageCharge.find(:all, params: {recurring_application_charge_id: 654381177}) | ||
|
|
||
| assert_equal 2, usage_charges.length |
There was a problem hiding this comment.
add a test for RecurringAppCharges with no usage charges
ch33sybr3ad
force-pushed
the
usage_charge_resource
branch
3 times, most recently
from
d867423
to
933754e
Compare
|
👍 |
1 similar comment
|
👍 |
ch33sybr3ad
added a commit
that referenced
this pull request
Feb 10, 2016
adding usage charge resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Shopify/finance @dominiquesr @Not-Jake