From f5aaf8ce61c23ab970edbb14cbc6b42f08df5884 Mon Sep 17 00:00:00 2001 From: Nelson Date: Tue, 5 Mar 2024 13:38:53 -0500 Subject: [PATCH] bump dependency to latest major version of the API (#1801) * bump dependency to latest major version of the API * drop ruby 2.7 from CI * increase mimimum ruby to 3.0 * allow API gem to be released to major/minor versions without requiring dependency changes here * allow patches and minor releases of api without requiring releasing this gem * update rubocop ruby version * ruby 3.2 for rubocop * breaking changelog * reorder breaking chang --- .github/workflows/build.yml | 2 +- .github/workflows/rubocop.yml | 4 ++-- CHANGELOG.md | 1 + Gemfile.lock | 4 ++-- shopify_app.gemspec | 4 ++-- 5 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 49d289323..e24f719e4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -12,7 +12,7 @@ jobs: name: Ruby ${{ matrix.version }} strategy: matrix: - version: ['2.7', '3.0', '3.1', '3.2'] + version: ['3.0', '3.1', '3.2'] steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/rubocop.yml b/.github/workflows/rubocop.yml index d4bcf6bf9..3d14f5795 100644 --- a/.github/workflows/rubocop.yml +++ b/.github/workflows/rubocop.yml @@ -8,10 +8,10 @@ jobs: steps: - uses: actions/checkout@v3 - - name: Set up Ruby 2.7 + - name: Set up Ruby 3.2 uses: ruby/setup-ruby@v1 with: - ruby-version: 2.7 + ruby-version: 3.2 bundler-cache: true - name: Install gems run: | diff --git a/CHANGELOG.md b/CHANGELOG.md index 513d9a45e..119ea469a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ Unreleased ---------- +* ⚠️ [Breaking] Bumps minimum supported Ruby version to 3.0. Bumps `shopify_api` to 14.0 [1801](https://github.com/Shopify/shopify_app/pull/1801) * Make type param for webhooks route optional. This will fix a bug with CLI initiated webhooks.[1786](https://github.com/Shopify/shopify_app/pull/1786) * Fix redirecting to login when we catch a 401 response from Shopify, so that it can also handle cases where the app is already embedded when that happens.[1787](https://github.com/Shopify/shopify_app/pull/1787) * Always register webhooks with offline sessions.[1788](https://github.com/Shopify/shopify_app/pull/1788) diff --git a/Gemfile.lock b/Gemfile.lock index adc09cce4..f863e7083 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -8,7 +8,7 @@ PATH jwt (>= 2.2.3) rails (> 5.2.1) redirect_safely (~> 1.0) - shopify_api (~> 13.4) + shopify_api (~> 14) sprockets-rails (>= 2.0.0) GEM @@ -217,7 +217,7 @@ GEM ruby-progressbar (1.13.0) ruby2_keywords (0.0.5) securerandom (0.2.2) - shopify_api (13.4.0) + shopify_api (14.0.0) activesupport concurrent-ruby hash_diff diff --git a/shopify_app.gemspec b/shopify_app.gemspec index cfa189165..1f8763f19 100644 --- a/shopify_app.gemspec +++ b/shopify_app.gemspec @@ -10,7 +10,7 @@ Gem::Specification.new do |s| s.author = "Shopify" s.summary = "This gem is used to get quickly started with the Shopify API" - s.required_ruby_version = ">= 2.7" + s.required_ruby_version = ">= 3.0" s.metadata["allowed_push_host"] = "https://rubygems.org" @@ -20,7 +20,7 @@ Gem::Specification.new do |s| s.add_runtime_dependency("jwt", ">= 2.2.3") s.add_runtime_dependency("rails", "> 5.2.1") s.add_runtime_dependency("redirect_safely", "~> 1.0") - s.add_runtime_dependency("shopify_api", "~> 13.4") + s.add_runtime_dependency("shopify_api", "~> 14") s.add_runtime_dependency("sprockets-rails", ">= 2.0.0") s.add_development_dependency("byebug")