Bypass application layout rendering for SessionsController

[mariusbutuc]

The SessionsController inherits rendering using the application layout.

By default, render with no layout at all.

/review @kevinhughes27 @alexcoco @swalkinshaw
/cc @nickhoffman

[alexcoco]

The new action should be rendered without a layout, why not update the session concern and set layout false for that action

[nickhoffman]

@alexcoco, what's the benefit of specifying no layout for the new action only?

[alexcoco]

The difference is that if someone inherits this controller then you're disabling it for all the actions even the ones that they add. I rather it be more explicit.

[nickhoffman]

I usually err on the side of explicitness too. However, I figured that inheriting from this controller and adding actions is uncommon, and when it does occur, the application's default layout wouldn't be wanted. But if your experience says otherwise, 👍

[kevinhughes27]

I would prefer the explicitness as well

[mariusbutuc]

Disabling the layout rendering moved into the concern, and it is now scoped to the #new action only, as of 069d708.

@kevinhughes27 @alexcoco @nickhoffman please have another look.

[nickhoffman]

Code LGTM. 🚢 once you bump the version and CI is green.

[kevinhughes27]

👍

[alexcoco]

👍