Only delete remote files when necessary with theme watch command #25

Merged
merged 2 commits into from May 14, 2013

Conversation

Projects
None yet
3 participants

Because files that are present locally overwrite remote files anyway, it is not necessary to delete all files on every execution of theme watch.

Only files that are not present locally are deleted on the remote side. Speeds up the command extraordinarily in projects with tons of assets (-> nearly all projects).

Includes fix from #21

Daniel Lindenkreuz added some commits Mar 1, 2013

Daniel Lindenkreuz Only delete remote files when necessary with theme watch command
Because files that are present locally overwrite remote files anyway,
it is not necessary to delete all files on every execution of `theme
watch`.

Only files that are not present locally are deleted on the remote side.
Speeds up the command extraordinarily in projects with tons of assets
(-> nearly all projects).
bfc8a0e
Daniel Lindenkreuz See pull request #21 by joelongstreet
Fix 'errors_from_response'

#21

I hope the project owner is still active…
bbb5bcf

@dlindenkreuz, does your pull request cause locally deleted files (when watching a theme) to be deleted remotely?

This would be ideal. @jduff, how is this supposed to work? At present, it seems if I delete a file while watching, it doesn't get deleted remotely.

Contributor

jduff commented May 14, 2013

@galenking this change doesn't do what you are saying, this is for the replace command to avoid unnecessary deletes when replacing the theme.

I can't remember why I didn't have watch delete files, maybe because it wasn't as common to remove files? A pull request to change that would be welcome.

@jduff jduff added a commit that referenced this pull request May 14, 2013

@jduff jduff Merge pull request #25 from dlindenkreuz/master
Only delete remote files when necessary with theme watch command
c976c61

@jduff jduff merged commit c976c61 into Shopify:master May 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment