This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
remove theme-support email, not theirs to support #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertiful
suggested changes
May 22, 2017
src/config/settings_schema.json
Outdated
| "theme_author": "Shopify", | ||
| "theme_documentation_url": "https://github.com/Shopify/slate", | ||
| "theme_support_email": "theme-support@shopify.com" | ||
| "theme_support_url": "https://shopify.github.io/slate/" |
There was a problem hiding this comment.
Should this just be theme_support_email: slate@shopify.com instead? The theme_documentation_url is already there above.
There was a problem hiding this comment.
Conscious choice. I don't want our email showing up in someone's production site 😝
If anything, I should switch the URLs for documentation and support. Gonna do that now.
bertiful
approved these changes
May 22, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Update the
theme_infoto remove Theme Support as the support email. That group is not responsible for maintaining the code base.Switched it for
theme_support_urlso theme devs still know that you can separate the ideas of documentations and support.Changed the theme version number to represent what we do for internally developed themes where the
theme_versionmatches thepackage.jsonversion.Checklist
For contributors:
For maintainers:
package.jsonversion in a separate PR, if applicable.