Metric name lambdas #19

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@himynameisjonas

Send a lambda instead of a string as the metric name to dynamically set the name of the metric. Useful when measuring sub classes

@jstorimer

I think this is fine.

In the past, I've simply iterated over the subclasses I want to instrument and added the instrumentation directly.

@jstorimer

Can you rebase your changes against the latest master and make sure the tests pass? Then I'll merge.

@himynameisjonas

I have rebased against the master now

@wvanbergen
Shopify member

Not sure what happened to this PR, but this functionality has been included in the gem for a while. Thanks for the suggestion!

@wvanbergen wvanbergen closed this Apr 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment