add set support #33

Merged
merged 2 commits into from Feb 6, 2014

2 participants

@disaacs

@wvanbergen Is there anything more to do here to support sets? Sets do not lend themselves to the indirect instrumenting approach.

I haven't actually tried this code out.

@wvanbergen
Shopify member

Code looks good, but let's add tests similar to the tests we have for e.g. gauges.

@disaacs

@wvanbergen added some tests.

@wvanbergen
Shopify member

Looking good. Waiting for a CI run....

@wvanbergen wvanbergen merged commit 6a04a68 into master Feb 6, 2014

1 check passed

Details default The Travis CI build passed
@wvanbergen wvanbergen deleted the set_support branch Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment