Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle gracefully if we get unparsable JSON #933

Merged
merged 1 commit into from May 13, 2022

Conversation

paracycle
Copy link
Member

@paracycle paracycle commented May 13, 2022

Motivation

We seem to sometimes not read enough bytes from the Sorbet output, which ends up causing us to get an error from the JSON parser. While we investigate and fix that root cause, we might as well gracefully handle JSON parsing errors.

Implementation

Rescue JSON parsing errors

Tests

No tests, since I don't know how to recreate this situation.

We seem to sometimes not read enough bytes from the Sorbet output, which
ends up causing us to get an error from the JSON parser. While we
investigate and fix that root cause, we might as well gracefully handle
JSON parsing errors.
@paracycle paracycle requested a review from Morriar May 13, 2022
@paracycle paracycle changed the title Fail gracefully if we get unparsable JSON Handle gracefully if we get unparsable JSON May 13, 2022
@paracycle paracycle enabled auto-merge May 13, 2022
@Morriar
Copy link
Collaborator

@Morriar Morriar commented May 13, 2022

Should we provide a warning or something?

@paracycle
Copy link
Member Author

@paracycle paracycle commented May 13, 2022

Should we provide a warning or something?

I mean this to be temporary to be honest, so I didn't do that.

@paracycle paracycle merged commit 55175c3 into main May 13, 2022
7 checks passed
@paracycle paracycle deleted the uk-suppress-json-parsing-errors branch May 13, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to production May 13, 2022 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to 0-8-stable May 30, 2022 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants