Repository navigation
Respect .prettierignore when formatting local files - #1056
Merged
Merged
Conversation
dejmedus
changed the title
dejmedus
force-pushed
the
jb-prettier-ignore
branch
from
September 19, 2025 23:54
20c6635 to
7fe1e7a
Compare
Previously, the extension used liquid prettier plugin to format all files regardless of whether there was a `.prettierignore` file in the workspace. Although we are unable to respect `.prettierignore` in browsers https://prettier.io/docs/en/browser or remote filesystems, we can when we have access to both full prettier and the vscode workspace This commit checks for a `.prettierignore` at the workspace root and does not format files that `.getFileInfo` determines should be ignored
dejmedus
force-pushed
the
jb-prettier-ignore
branch
from
December 20, 2025 00:40
7fe1e7a to
5b5a1f9
Compare
dejmedus
commented
Dec 20, 2025
| @@ -0,0 +1,74 @@ | |||
| import { describe, it, expect, vi, beforeEach } from 'vitest'; | |||
Contributor
Author
There was a problem hiding this comment.
It seemed okay to add a test here as src/*.spec.ts are excluded, but i'm happy to move or remove if preferred!
dejmedus
marked this pull request as ready for review
December 20, 2025 01:45
EvilGenius13
approved these changes
Jan 2, 2026
charlespwd
approved these changes
Jan 16, 2026
|
Looking forward for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Previously, the extension used liquid prettier plugin to format all files regardless of whether it was ignored by a
.prettierignorefile in the workspace. Although we aren't able to respect.prettierignorein all environments (for instance in browser or remote filesystems) we can innodePrettierFormatThis PR checks for a
.prettierignoreat the workspace root and does not format files that.getFileInfodetermines should be ignoreddemo
prettier-demo.mov
What did you learn?
.prettierignorefiles at workspace root (though its being discussed)Before you deploy
changeset