Add automatic environment variable loading and Variables in yml config. #589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
This PR encapsulates 2 main features.
This will allow developers to much more easily commit their code to public repos without revealing their passwords or their clients.
Environment variable loading
The normal user configuration paths are used so depending on OS the path used would be:
Windows:
%APPDATA%\Shopify\Themekit\variables
Linux/BSDs:
${XDG_CONFIG_HOME}/Shopify/Themekit/variables
MacOSX:
${HOME}/Library/Application Support/Shopify/Themekit/variables
Themekit will also look for a variables file within the project directory. There has also been a flag added
--vars
will provide a path to a variables file.The format of these files would look like a normal .env file:
Config file interpolation.
The config looks would like this:
and the commands can be run as normal. This will not add any breaking functionality and should not break any existing workflows
Warn Checklist