Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SIGTERM to exit cleanly #181

Merged
merged 1 commit into from May 25, 2017
Merged

Handle SIGTERM to exit cleanly #181

merged 1 commit into from May 25, 2017

Conversation

dlmiddlecote
Copy link

@dlmiddlecote dlmiddlecote commented May 25, 2017

Fixes #180

Copy link
Contributor

@sirupsen sirupsen left a comment

Should we make sure all the data pipes are flushed before exiting? 🤔

@jpittis
Copy link
Contributor

@jpittis jpittis commented May 25, 2017

That's the "right thing to do" but I can't imagine the use case. Toxiproxy only ever has a single user. (The individual or bot who is running the test suite.) If that user wants to kill Toxiproxy, why would they ever care about leftover state in the pipes?

@sirupsen
Copy link
Contributor

@sirupsen sirupsen commented May 25, 2017

Agree 👍 Let's ship it

@jpittis jpittis merged commit 6120943 into Shopify:master May 25, 2017
@dlmiddlecote dlmiddlecote deleted the issue-180 branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants