Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
only prepend `http://` to endpoint if no protocol was provided #191
client.NewClient("https://example.com") // Before: http://https//example.com // After: https://example.com
I would love to write a test for this but
This is an improvement over the current code. Thanks for opening a PR!
Because Toxiproxy does not support HTTPS, it might be nice to fail fast with a clear error message when an
https: protocol is provided.
IMO it would be appropriate to fail with a
log.Fatal("the toxiproxy client does not support https") if an HTTPS protocol is provided.