From 58026776a7e86f5fb2b1fd086ceec903d7577615 Mon Sep 17 00:00:00 2001
From: Brian Shen <brian.shen@shopify.com>
Date: Mon, 15 Jan 2024 16:31:24 +0000
Subject: [PATCH] drop runExtension support for customer account ui extension

---
 .changeset/lucky-beds-care.md                 |  6 ++++
 .../surfaces/customer-account/extension.ts    |  4 ---
 .../src/surfaces/customer-account/targets.ts  | 33 +------------------
 3 files changed, 7 insertions(+), 36 deletions(-)
 create mode 100644 .changeset/lucky-beds-care.md

diff --git a/.changeset/lucky-beds-care.md b/.changeset/lucky-beds-care.md
new file mode 100644
index 000000000..2d9587970
--- /dev/null
+++ b/.changeset/lucky-beds-care.md
@@ -0,0 +1,6 @@
+---
+'@shopify/ui-extensions': patch
+'@shopify/ui-extensions-react': patch
+---
+
+Drop runExtension support for customer account ui extension
diff --git a/packages/ui-extensions/src/surfaces/customer-account/extension.ts b/packages/ui-extensions/src/surfaces/customer-account/extension.ts
index 469e52ba0..debbc493e 100644
--- a/packages/ui-extensions/src/surfaces/customer-account/extension.ts
+++ b/packages/ui-extensions/src/surfaces/customer-account/extension.ts
@@ -19,7 +19,3 @@ export const extension =
  * @deprecated This is deprecated, use `extension` instead.
  */
 export const extend = extension;
-
-export interface RunExtension<Api, Return> {
-  (api: Api): Promise<Return>;
-}
diff --git a/packages/ui-extensions/src/surfaces/customer-account/targets.ts b/packages/ui-extensions/src/surfaces/customer-account/targets.ts
index 36722e043..5eb3ddc2b 100644
--- a/packages/ui-extensions/src/surfaces/customer-account/targets.ts
+++ b/packages/ui-extensions/src/surfaces/customer-account/targets.ts
@@ -2,7 +2,7 @@ import {AnyComponent} from '../checkout/shared';
 
 import {CartLineItemApi} from './api/cart-line/cart-line-item';
 import type {OrderStatusApi} from './api/order-status/order-status';
-import type {RenderExtension, RunExtension} from './extension';
+import type {RenderExtension} from './extension';
 import {
   StandardApi,
   FullExtensionNavigation,
@@ -102,18 +102,10 @@ export interface CustomerAccountExtensionTargets {
       FullPageApi,
     AllComponents
   >;
-  'CustomerAccount::Returns::Initiate': RunExtension<
-    StandardApi<'CustomerAccount::Returns::Initiate'> & {orderId: string},
-    void
-  >;
   'CustomerAccount::KitchenSink': RenderExtension<
     StandardApi<'CustomerAccount::KitchenSink'> & {name: string},
     AllComponents
   >;
-  'CustomerAccount::KitchenSinkRun': RunExtension<
-    StandardApi<'CustomerAccount::KitchenSinkRun'> & {name: string},
-    string
-  >;
   'customer-account.order-index.block.render': RenderExtension<
     StandardApi<'customer-account.order-index.block.render'>,
     AllComponents
@@ -273,29 +265,6 @@ export interface ActionExtensionApi {
 export type ApiForExtension<Target extends keyof ExtensionTargets> =
   ExtractedApiFromExtension<ExtensionTargets[Target]>;
 
-type ExtractedApiFromRunExtension<T> = T extends RunExtension<
-  infer Api,
-  unknown
->
-  ? Api
-  : never;
-
 type ExtractedApiFromExtension<T> = T extends RenderExtension<any, any>
   ? ExtractedApiFromRenderExtension<T>
-  : T extends RunExtension<any, any>
-  ? ExtractedApiFromRunExtension<T>
   : never;
-
-/**
- * A union type containing all extension targets that follow the pattern of
- * accepting an `api` argument, and using those arguments to run code that does not render anything, but instead return
- * a value or execute a side effect.
- */
-export type RunExtensionTarget = {
-  [Target in keyof ExtensionTargets]: ExtensionTargets[Target] extends RunExtension<
-    any,
-    any
-  >
-    ? Target
-    : never;
-}[keyof ExtensionTargets];