Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop runExtension support for customer account ui extension #1658

Conversation

brianshen1990
Copy link
Contributor

@brianshen1990 brianshen1990 commented Jan 15, 2024

Background

Part of step 4 ( have to do it in ui-extension side as well ) of this ticket https://github.com/Shopify/core-issues/issues/63160

Please also review customer account web side PR: https://github.com/Shopify/customer-account-web/pull/3701

  1. customer account repo: support render customer-account.order.action.menu-item.render if it is within return extension https://github.com/Shopify/customer-account-web/pull/3679
  2. return repo: add an customer-account.order.action.menu-item.render target extension and remove the CustomerAccount::Returns::Initiate target extension ( after step 1 is deployed ) https://github.com/Shopify/buyer-returns/pull/372
  3. customer account repo: remove requestReturn logic https://github.com/Shopify/customer-account-web/pull/3699
  4. customer account repo: remove the legacy CustomerAccount::Returns::Initiate
  5. customer account repo and return repo: once soft auth customer account api is supported, move the whether to render request return logic to return app
  6. drop the support for CustomerAccount::Returns::Initiate in core https://github.com/Shopify/shopify/blob/f646c61cdfe69b47ed1c9a82eff8d29eb866c7e0/components/apps/app/services/apps/models/ui_extension/schema/groups/customer_account_ui.rb

Solution

(Describe your solution, why this approach was chosen, and what the alternatives/impacts may be)

🎩

See tophat of this ticket https://github.com/Shopify/customer-account-web/pull/3701

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@brianshen1990 brianshen1990 marked this pull request as ready for review January 15, 2024 16:49
@brianshen1990 brianshen1990 self-assigned this Jan 15, 2024
Copy link
Member

@robin-drexler robin-drexler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So beautiful! It's been a long time coming. ❤️

Copy link
Contributor

@lihaokx lihaokx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianshen1990 brianshen1990 merged commit a978ed8 into unstable Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants