Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Update to get wolverine working with the redis gem (redis-rb) #4

Merged
merged 4 commits into from Jan 3, 2013
Merged

Update to get wolverine working with the redis gem (redis-rb) #4

merged 4 commits into from Jan 3, 2013

Conversation

lvenegas
Copy link
Contributor

@lvenegas lvenegas commented Jan 3, 2013

Hi,

I had some issues trying to get wolverine up and running so I dug deeper and found that the redis-rb implementation of eval and evalsha (actually _eval) only expect 2 arguments instead of the 3 that wolverine was passing through.

The number of keys don't need to be passed through since redis-rb simply gets it from the size of the keys array.

I looked through the redis-rb (master) history and it looks like eval and evalsha always expected 2 arguments, I assume that you built wolverine on a fork off master before they settled on the final implementation...

Anyway, I'd appreciate it if you could review/merge my pull request which updates wolverine to work with redis-rb.

Thanks,

Leo Venegas

@burke
Copy link
Member

burke commented Jan 3, 2013

Haha, looks like you're right. We are using a forked redis-rb. I didn't even realize. Coincidentally enough, I ran into this same problem last night when I tried to use wolverine outside of shopify for the first time. Your solution looks pretty much like a more carefully implemented version of my changes. Thanks for the contribution :)

burke added a commit that referenced this pull request Jan 3, 2013
Update to get wolverine working with the redis gem (redis-rb)
@burke burke merged commit 2660f8e into Shopify:master Jan 3, 2013
@lvenegas
Copy link
Contributor Author

lvenegas commented Jan 4, 2013

Great, thanks for merging in the changes. Could you please release an updated gem to rubygems.org?

Thanks again,

Leo

@burke
Copy link
Member

burke commented Jan 7, 2013

Done

@maxwells maxwells mentioned this pull request Mar 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants