This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Update to get wolverine working with the redis gem (redis-rb) #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had some issues trying to get wolverine up and running so I dug deeper and found that the redis-rb implementation of eval and evalsha (actually _eval) only expect 2 arguments instead of the 3 that wolverine was passing through.
The number of keys don't need to be passed through since redis-rb simply gets it from the size of the keys array.
I looked through the redis-rb (master) history and it looks like eval and evalsha always expected 2 arguments, I assume that you built wolverine on a fork off master before they settled on the final implementation...
Anyway, I'd appreciate it if you could review/merge my pull request which updates wolverine to work with redis-rb.
Thanks,
Leo Venegas