Use paths that are more "environment-friendly" #329

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@andsild
andsild commented Aug 13, 2016

Regarding commit 39a89f4:
http://stackoverflow.com/a/16365367
http://stackoverflow.com/a/21613044

Commit 0282b16:
/usr/lib doesn't exist on my system so the test fails (NixOS). /usr/bin has to exist on all UNIX systems

@Shougo Shougo commented on the diff Aug 14, 2016
run_tests.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
@Shougo
Shougo Aug 14, 2016 Owner

Why did you change it?
I don' think this change is needed.

@tweekmonster
tweekmonster Aug 14, 2016 Contributor

I've run into cases where /bin/bash doesn't actually exist and /usr/bin/env bash was more reliable. I think it was on FreeBSD.

OTH, the contents of run_tests.sh could be placed in Makefile.

@Shougo Shougo added a commit that closed this pull request Aug 15, 2016
@Shougo Fix #329 tests cb7cef8
@Shougo Shougo closed this in cb7cef8 Aug 15, 2016
@Shougo
Owner
Shougo commented Aug 15, 2016

Thank you. I have fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment