New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve document consistency and clarity #870

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
4 participants
@brianvanburken
Contributor

brianvanburken commented Nov 7, 2018

I was reading the documentation with :help deoplete-optiosn, as a new user, and found some inconsistency issues and unknown units.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 7, 2018

Codecov Report

Merging #870 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   49.12%   49.12%           
=======================================
  Files          15       15           
  Lines         741      741           
=======================================
  Hits          364      364           
  Misses        377      377

@Shougo Shougo merged commit abbae02 into Shougo:master Nov 7, 2018

3 checks passed

codecov/changes No unexpected coverage changes found.
Details
codecov/patch Coverage not affected when comparing aa43a5f...1d28894
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kiryph

This comment has been minimized.

Contributor

kiryph commented Nov 8, 2018

In my opinion the change default value: v:false to default value: false is misleading. There is no keyword false (or true) in vim. A beginner could think to use false or true. This does not work. Either you use 0/1 or the special value v:false/v:true.

@Shougo

This comment has been minimized.

Owner

Shougo commented Nov 8, 2018

Hm. OK. I will replace it later.

@brianvanburken brianvanburken deleted the brianvanburken:fix-docs branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment