Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maxLen #284

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Fix maxLen #284

merged 1 commit into from
Mar 9, 2025

Conversation

peterjan
Copy link
Member

@peterjan peterjan commented Mar 7, 2025

There are several instances where maxLen returns a size that doesn't take into account a transaction being part of the request. While updating I noticed some values diverged from their impl probably due to changes being made to the request/response structs over time. I took them along with me but the important ones are the reasonableTransactionSetSize ones of course.

I found out because my v2 migration on my node, which was chugging along nicely, halted all of a sudden. Contracts were no longer being refreshed, resulting in empty accounts, resulting in failed migrations. One thing that's puzzling me a bit though is the error message: "couldn't renew/refresh contract: host responded with error: failed to read host inputs response: failed to read request: EOF ". That error message seems impossible, I double checked and I still can't explain how you could ever get failed to read response, failed to read request.

@peterjan peterjan self-assigned this Mar 7, 2025
@ChrisSchinnerl
Copy link
Member

One thing that's puzzling me a bit though is the error message: "couldn't renew/refresh contract: host responded with error: failed to read host inputs response: failed to read request: EOF ". That error message seems impossible, I double checked and I still can't explain how you could ever get failed to read response, failed to read request.

That's because the host is getting the EOF when reading the request and returns it to the renter. The renter reads the response, gets the error instead of the inputs and then reports that the host responded with an error when we tried to read the inputs response and the error the host sent is EOF.

@lukechampine lukechampine merged commit d652370 into master Mar 9, 2025
10 checks passed
@lukechampine lukechampine deleted the pj/max-len branch March 9, 2025 17:09
@peterjan peterjan mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants