Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1,v2: Return available data alongside error #1

Merged
merged 2 commits into from
Sep 14, 2024
Merged

v1,v2: Return available data alongside error #1

merged 2 commits into from
Sep 14, 2024

Conversation

lukechampine
Copy link
Member

If we have both data and an error, we should always return all of the buffered data before surfacing the error.

@n8maninger
Copy link
Member

@lukechampine is this still needed?

@lukechampine
Copy link
Member Author

not strictly necessary, but it does clean up a few things, might as well merge it

@n8maninger n8maninger merged commit b7fef91 into master Sep 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants