Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peers panel #181

Merged
merged 2 commits into from Aug 22, 2018
Merged

Add peers panel #181

merged 2 commits into from Aug 22, 2018

Conversation

kernelwhisperer
Copy link
Contributor

@kernelwhisperer kernelwhisperer commented Aug 22, 2018

What changed?

Allow users to connect to other peers as well as see their multi address.
In the Settings there is a new panel dedicated to that.

Copy link
Member

@koalalorenzo koalalorenzo left a comment

Should we add some tests?

if (!this.props.informationStore.loaded) return null

const { addresses } = this.props.informationStore.peer
const nonLocalHostAdresses = addresses.filter(addr =>
Copy link
Member

@koalalorenzo koalalorenzo Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do a reverse so we see the public ip first?

@koalalorenzo koalalorenzo merged commit 55ed215 into master Aug 22, 2018
2 checks passed
@koalalorenzo koalalorenzo deleted the feature/add-peers-panel branch Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants