Repository navigation
Use centroid based positioning for gestures - #290
Merged
Merged
Conversation
Contributor
Fly Preview Deployments - Completed ✅ |
snide
changed the title
Contributor
Author
|
@dgreenheck for your curiosity, this PR fixed the Firefox issue with gestures. It also makes them feel MUCH better because it calculates the center point a lot more accurately. I guess the technical term for this concept is "centroid" based positioning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with gestures causing some boundary issues in FF mobile. Also makes the center of the rotation feel better because it uses a point in between the fingers as the rotation.