New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigil create new epub3, epubcheck failed. #250

Closed
JackieFei opened this Issue Nov 8, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@JackieFei

JackieFei commented Nov 8, 2016

How to reproduce:

  1. Preferences > General Settings > Create New or Empty Epubs as: Version 3 > OK
  2. File > New > Save
  3. Use epubcheck 4.0.1 (or Sigil epubcheck plugin) to check this epub, got the error:
    Validating using EPUB version 3.0.1 rules.
    ERROR(OPF-073): e3.epub/OEBPS/toc.ncx(3,52): External identifiers must not appear in the document type declaration.
  4. Remove the toc.ncx line 2 and 3 (see below), epubcheck will completed.
@kevinhendricks

This comment has been minimized.

Show comment
Hide comment
@kevinhendricks

kevinhendricks Nov 8, 2016

Contributor

That may be an error in epubcheck. Doctypes on pure xml files like the toc.ncx are allowed and are needed for backwards compatibility with epub2 readers. The dtd is allowed to be there as well again for backwards compatibility. I think there is an official epubcheck bug already filed on this someplace on their site.

Sent from my iPad

On Nov 7, 2016, at 8:37 PM, JackieFei notifications@github.com wrote:

How to reproduce:

Preferences > General Settings > Create New or Empty Epubs as: Version 3 > OK
File > New > Save
Use epubcheck 4.0.1 (or Sigil epubcheck plugin) to check this epub, got the error:
Validating using EPUB version 3.0.1 rules.
ERROR(OPF-073): e3.epub/OEBPS/toc.ncx(3,52): External identifiers must not appear in the document type declaration.
Remove the toc.ncx line 2 and 3 (see below), epubcheck will completed.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Contributor

kevinhendricks commented Nov 8, 2016

That may be an error in epubcheck. Doctypes on pure xml files like the toc.ncx are allowed and are needed for backwards compatibility with epub2 readers. The dtd is allowed to be there as well again for backwards compatibility. I think there is an official epubcheck bug already filed on this someplace on their site.

Sent from my iPad

On Nov 7, 2016, at 8:37 PM, JackieFei notifications@github.com wrote:

How to reproduce:

Preferences > General Settings > Create New or Empty Epubs as: Version 3 > OK
File > New > Save
Use epubcheck 4.0.1 (or Sigil epubcheck plugin) to check this epub, got the error:
Validating using EPUB version 3.0.1 rules.
ERROR(OPF-073): e3.epub/OEBPS/toc.ncx(3,52): External identifiers must not appear in the document type declaration.
Remove the toc.ncx line 2 and 3 (see below), epubcheck will completed.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@kevinhendricks

This comment has been minimized.

Show comment
Hide comment
@kevinhendricks

kevinhendricks Nov 8, 2016

Contributor

FWIW, I think we could modify the code to remove the DOCTYPE on the toc.ncx just for epub3, but it really makes no sense given the only reason to have a toc.ncx under epub3 is for backwards compatibility with epub2 ereaders. I will look into this as epubcheck rarely if ever updates and fixes its own bugs.

Contributor

kevinhendricks commented Nov 8, 2016

FWIW, I think we could modify the code to remove the DOCTYPE on the toc.ncx just for epub3, but it really makes no sense given the only reason to have a toc.ncx under epub3 is for backwards compatibility with epub2 ereaders. I will look into this as epubcheck rarely if ever updates and fixes its own bugs.

@JackieFei

This comment has been minimized.

Show comment
Hide comment
@JackieFei

JackieFei commented Nov 8, 2016

@JackieFei

This comment has been minimized.

Show comment
Hide comment
@JackieFei

JackieFei Nov 8, 2016

epubcheck has a closed issue above.

JackieFei commented Nov 8, 2016

epubcheck has a closed issue above.

@dougmassay

This comment has been minimized.

Show comment
Hide comment
@dougmassay

dougmassay Nov 8, 2016

Contributor

For what it's worth, none of the commercial epub3s I'm seeing include the DOCTYPE in the NCX. And I'm seeing no compatibilty issues in epub2 reading systems (mainly older ADE on desktops and RMSDK-based portables) as a result.

Contributor

dougmassay commented Nov 8, 2016

For what it's worth, none of the commercial epub3s I'm seeing include the DOCTYPE in the NCX. And I'm seeing no compatibilty issues in epub2 reading systems (mainly older ADE on desktops and RMSDK-based portables) as a result.

@kevinhendricks

This comment has been minimized.

Show comment
Hide comment
@kevinhendricks

kevinhendricks Nov 8, 2016

Contributor

Just committed fix for this to master. Closing this issue.
Thank you for your bug report!

Contributor

kevinhendricks commented Nov 8, 2016

Just committed fix for this to master. Closing this issue.
Thank you for your bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment