Permalink
Browse files

Removing extraneous call to IHttpClient.Initialize (#3830)

An extraneous call to IHttpClient.Initialize when sending the start requests resets httpClients in the DefaultHttpClient. This may break load balancers and prevent reusing HTTPS connections (SSL negotation will happen twice - once for negotiate and once for start)

More: #3829
1 parent 6f5c68b commit 0b362f67dea4ef9f8ac02d7b04271299fe32b699 @moozzyk moozzyk committed on GitHub Dec 22, 2016
Showing with 0 additions and 2 deletions.
  1. +0 −2 src/Microsoft.AspNet.SignalR.Client/Transports/TransportHelper.cs
@@ -57,8 +57,6 @@ public virtual Task<string> GetStartResponse(IHttpClient httpClient, IConnection
var startUrl = UrlBuilder.BuildStart(connection, transport, connectionData);
- httpClient.Initialize(connection);
-
return httpClient.Get(startUrl, connection.PrepareRequest, isLongRunning: false)
.Then(response => response.ReadAsString());
}

3 comments on commit 0b362f6

@peters
peters commented on 0b362f6 Jan 23, 2017

@moozzyk Any chance of a new release regarding this fix?

@moozzyk
Contributor

We don't have a date at this point but have already started thinking about a servicing release (2.2.2). Stay tuned.

@peters
peters commented on 0b362f6 Jan 23, 2017

👍

Please sign in to comment.