Skip to content

Commit

Permalink
Removed redundant platform specific code
Browse files Browse the repository at this point in the history
  • Loading branch information
abnanda1 committed Apr 29, 2013
1 parent 2b103fb commit 2bde2bc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 18 deletions.
11 changes: 1 addition & 10 deletions src/Microsoft.AspNet.SignalR.Client/Http/HttpHelper.cs
Expand Up @@ -67,10 +67,9 @@ private static Task<HttpWebResponse> PostInternal(string url, Action<HttpWebRequ

request.Method = "POST";
request.ContentType = "application/x-www-form-urlencoded";
#if !WINDOWS_PHONE && !SILVERLIGHT

// Set the content length if the buffer is non-null
request.ContentLength = buffer != null ? buffer.LongLength : 0;
#endif

if (buffer == null)
{
Expand Down Expand Up @@ -114,15 +113,7 @@ private static byte[] ProcessPostData(IDictionary<string, string> postData)
private static HttpWebRequest CreateWebRequest(string url)
{
HttpWebRequest request = null;
#if WINDOWS_PHONE
request = (HttpWebRequest)WebRequest.Create(url);
request.AllowReadStreamBuffering = false;
#elif SILVERLIGHT
request = (HttpWebRequest)System.Net.Browser.WebRequestCreator.ClientHttp.Create(new Uri(url));
request.AllowReadStreamBuffering = false;
#else
request = (HttpWebRequest)WebRequest.Create(url);
#endif
return request;
}
}
Expand Down
Expand Up @@ -19,15 +19,13 @@ public class HttpWebRequestWrapper : IRequest
{ HttpRequestHeader.ContentType.ToString(), (request, value) => { request.ContentType = value; } },
{ HttpRequestHeader.ContentLength.ToString(), (request, value) => { request.ContentLength = Int32.Parse(value, CultureInfo.CurrentCulture); } },
{ HttpRequestHeader.UserAgent.ToString(), (request, value) => { request.UserAgent = value; } },
#if (!WINDOWS_PHONE && !SILVERLIGHT)
{ HttpRequestHeader.Connection.ToString(), (request, value) => { request.Connection = value; } },
{ HttpRequestHeader.Date.ToString(), (request, value) => {request.Date = DateTime.Parse(value, CultureInfo.CurrentCulture); } },
{ HttpRequestHeader.Expect.ToString(), (request, value) => {request.Expect = value;} },
{ HttpRequestHeader.Host.ToString(), (request, value) => {request.Host = value; } },
{ HttpRequestHeader.IfModifiedSince.ToString(), (request, value) => {request.IfModifiedSince = DateTime.Parse(value, CultureInfo.CurrentCulture);} },
{ HttpRequestHeader.Referer.ToString(), (request, value) => { request.Referer = value; } },
{ HttpRequestHeader.TransferEncoding.ToString(), (request, value) => { request.TransferEncoding = value; } },
#endif
};

public HttpWebRequestWrapper(HttpWebRequest request)
Expand Down Expand Up @@ -83,7 +81,6 @@ public string Accept
}
}

#if !SILVERLIGHT
public IWebProxy Proxy
{
get
Expand All @@ -95,7 +92,6 @@ public IWebProxy Proxy
_request.Proxy = value;
}
}
#endif

public void Abort()
{
Expand All @@ -113,9 +109,7 @@ public void SetRequestHeaders(IDictionary<string, string> headers)
{
if (!_restrictedHeadersSet.Keys.Contains(headerEntry.Key))
{
#if (!WINDOWS_PHONE && !SILVERLIGHT)
_request.Headers.Add(headerEntry.Key, headerEntry.Value);
#endif
}
else
{
Expand All @@ -129,7 +123,6 @@ public void SetRequestHeaders(IDictionary<string, string> headers)
}
}

#if (NET4 || NET45)
public void AddClientCerts(X509CertificateCollection certificates)
{
if (certificates == null)
Expand All @@ -139,6 +132,5 @@ public void AddClientCerts(X509CertificateCollection certificates)

_request.ClientCertificates = certificates;
}
#endif
}
}

0 comments on commit 2bde2bc

Please sign in to comment.