Delete DOM nodes in forever frame in JS client after every 50th recei…

…ved message. Fixes #458
SignalR · Jun 19, 2012 · 301d603 · 301d603
1 parent dcabd78
commit 301d603
Show file tree

Hide file tree

Showing 8 changed files with 164 additions and 123 deletions.
diff --git a/SignalR.sln b/SignalR.sln
diff --git a/SignalR/Scripts/jquery.signalR.js b/SignalR/Scripts/jquery.signalR.js
@@ -933,7 +933,19 @@
                 transportLogic.ajaxSend(connection, data);
             },
 
-            receive: transportLogic.processMessages,
+            receive: function (connection, data) {
+                var cw;
+                transportLogic.processMessages(connection, data);
+                // Delete the script & div elements
+                connection.frameMessageCount = (connection.frameMessageCount || 0) + 1;
+                if (connection.frameMessageCount > 50) {
+                    connection.frameMessageCount = 0;
+                    cw = connection.frame.contentWindow || connection.frame.contentDocument;
+                    if (cw && cw.document) {
+                        $("body", cw.document).empty();
+                    }
+                }
+            },
 
             stop: function (connection) {
                 var cw = null;

diff --git a/SignalR/Scripts/jquery.signalR.min.js b/SignalR/Scripts/jquery.signalR.min.js
diff --git a/SignalR/Transports/ForeverFrameTransport.cs b/SignalR/Transports/ForeverFrameTransport.cs
@@ -6,9 +6,10 @@ namespace SignalR.Transports
 {
     public class ForeverFrameTransport : ForeverTransport
     {
-        private const string _initPrefix = "<!DOCTYPE html><html><head>" +
-                                           "<title>SignalR Forever Frame Transport Stream</title></head>\r\n" +
-                                           "<body>\r\n" +
+        private const string _initPrefix = "<!DOCTYPE html>" +
+                                           "<html>" +
+                                           "<head>" +
+                                           "<title>SignalR Forever Frame Transport Stream</title>\r\n" +
                                            "<script>\r\n" + //"    debugger;\r\n"+
                                            "    var $ = window.parent.jQuery,\r\n" +
                                            "        ff = $ ? $.signalR.transports.foreverFrame : null,\r\n" +
@@ -17,7 +18,8 @@ public class ForeverFrameTransport : ForeverTransport
         private const string _initSuffix = "') : null,\r\n" +
                                             "        r = ff ? ff.receive : function() {};\r\n" +
                                             "    ff ? ff.started(c) : '';" +
-                                            "</script>";
+                                            "</script></head>" + 
+                                            "<body>\r\n";
 
         private readonly bool _isDebug;
 

diff --git a/samples/SignalR.Hosting.AspNet.Samples/Scripts/jquery.signalR.js b/samples/SignalR.Hosting.AspNet.Samples/Scripts/jquery.signalR.js
@@ -933,7 +933,19 @@
                 transportLogic.ajaxSend(connection, data);
             },
 
-            receive: transportLogic.processMessages,
+            receive: function (connection, data) {
+                var cw;
+                transportLogic.processMessages(connection, data);
+                // Delete the script & div elements
+                connection.frameMessageCount = (connection.frameMessageCount || 0) + 1;
+                if (connection.frameMessageCount > 50) {
+                    connection.frameMessageCount = 0;
+                    cw = connection.frame.contentWindow || connection.frame.contentDocument;
+                    if (cw && cw.document) {
+                        $("body", cw.document).empty();
+                    }
+                }
+            },
 
             stop: function (connection) {
                 var cw = null;

diff --git a/samples/SignalR.Hosting.AspNet.Samples/Scripts/jquery.signalR.min.js b/samples/SignalR.Hosting.AspNet.Samples/Scripts/jquery.signalR.min.js
diff --git a/samples/SignalR.Hosting.Owin.Samples/Content/Scripts/jquery.signalR.js b/samples/SignalR.Hosting.Owin.Samples/Content/Scripts/jquery.signalR.js
@@ -933,7 +933,19 @@
                 transportLogic.ajaxSend(connection, data);
             },
 
-            receive: transportLogic.processMessages,
+            receive: function (connection, data) {
+                var cw;
+                transportLogic.processMessages(connection, data);
+                // Delete the script & div elements
+                connection.frameMessageCount = (connection.frameMessageCount || 0) + 1;
+                if (connection.frameMessageCount > 50) {
+                    connection.frameMessageCount = 0;
+                    cw = connection.frame.contentWindow || connection.frame.contentDocument;
+                    if (cw && cw.document) {
+                        $("body", cw.document).empty();
+                    }
+                }
+            },
 
             stop: function (connection) {
                 var cw = null;

diff --git a/samples/SignalR.Hosting.Owin.Samples/Content/Scripts/jquery.signalR.min.js b/samples/SignalR.Hosting.Owin.Samples/Content/Scripts/jquery.signalR.min.js