Throw a nicer error when invoking hub method and connection hasn't st…

…arted.
SignalR · Aug 19, 2012 · 4561f0f · 4561f0f
1 parent efb462b
commit 4561f0f
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/SignalR/Scripts/hubs.js b/SignalR/Scripts/hubs.js
@@ -84,13 +84,26 @@
                 if ($.isFunction(userCallback)) {
                     userCallback.call(hub, result);
                 }
-            };
+            },
+            connection = hub._.connection();
 
         if ($.isFunction(userCallback)) {
             // Replace user's callback with our own
             args = $.merge(args.splice(0, args.length - 1), [callback]);
         }
 
+        if (!hub._.proxy) {
+            if (connection.state === signalR.connectionState.disconnected) {
+                // Connection hasn't been started yet
+                throw "SignalR: Connection must be started before data can be sent. Call .start() before .send()";
+            }
+
+            if (connection.state === signalR.connectionState.connecting) {
+                // Connection hasn't been started yet
+                throw "SignalR: Connection has not been fully initialized. Use .start().done() or .start().fail() to run logic after the connection has started.";
+            }
+        }
+
         // Update proxy state from hub state
         $.extend(hub._.proxy.state, copy(hub, ["_"]));
 

diff --git a/samples/SignalR.Hosting.AspNet.Samples/Scripts/hubs.js b/samples/SignalR.Hosting.AspNet.Samples/Scripts/hubs.js
@@ -84,13 +84,26 @@
                 if ($.isFunction(userCallback)) {
                     userCallback.call(hub, result);
                 }
-            };
+            },
+            connection = hub._.connection();
 
         if ($.isFunction(userCallback)) {
             // Replace user's callback with our own
             args = $.merge(args.splice(0, args.length - 1), [callback]);
         }
 
+        if (!hub._.proxy) {
+            if (connection.state === signalR.connectionState.disconnected) {
+                // Connection hasn't been started yet
+                throw "SignalR: Connection must be started before data can be sent. Call .start() before .send()";
+            }
+
+            if (connection.state === signalR.connectionState.connecting) {
+                // Connection hasn't been started yet
+                throw "SignalR: Connection has not been fully initialized. Use .start().done() or .start().fail() to run logic after the connection has started.";
+            }
+        }
+
         // Update proxy state from hub state
         $.extend(hub._.proxy.state, copy(hub, ["_"]));