Hub Clients.Client(null).foo() should throw same as PersistentConnection Connection.Send(null, message) #1265

Closed
Xiaohongt opened this Issue Jan 8, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@Xiaohongt
Contributor

Xiaohongt commented Jan 8, 2013

in Hub Clients.Client(null).foo() doesn't throw
in PersistentConnection Connection.Send(null, message) throw

@ghost ghost assigned abnanda1 Feb 22, 2013

@abnanda1

This comment has been minimized.

Show comment
Hide comment
@abnanda1

abnanda1 Mar 5, 2013

Contributor

This issue has already been fixed.

Contributor

abnanda1 commented Mar 5, 2013

This issue has already been fixed.

@abnanda1 abnanda1 closed this Mar 5, 2013

@abnanda1 abnanda1 reopened this Mar 6, 2013

abnanda1 added a commit that referenced this issue Mar 6, 2013

Added a null check for the Send and Group methods in Hub and Persiste…
…nt Connection

- Added the corresponding unit tests for the null cases

#1265
@Xiaohongt

This comment has been minimized.

Show comment
Hide comment
@Xiaohongt

Xiaohongt Mar 7, 2013

Contributor

we should also throw for empty connectionId here

Contributor

Xiaohongt commented Mar 7, 2013

we should also throw for empty connectionId here

abnanda1 added a commit that referenced this issue Mar 7, 2013

@abnanda1

This comment has been minimized.

Show comment
Hide comment
@abnanda1

abnanda1 Mar 7, 2013

Contributor

I have added the checks for empty values. Please verify.

Contributor

abnanda1 commented Mar 7, 2013

I have added the checks for empty values. Please verify.

chenriks pushed a commit to chenriks/SignalR that referenced this issue Mar 7, 2013

Added a null check for the Send and Group methods in Hub and Persiste…
…nt Connection

- Added the corresponding unit tests for the null cases

#1265

chenriks pushed a commit to chenriks/SignalR that referenced this issue Mar 7, 2013

abnanda1 added a commit that referenced this issue Mar 8, 2013

Made changes as per code review feedback
- Added the null or empty error message to the Resources file
#1265

abnanda1 added a commit that referenced this issue Mar 8, 2013

Made changes as per code review feedback
- Added the null or empty error message to the Resources file
#1265
@Xiaohongt

This comment has been minimized.

Show comment
Hide comment
@Xiaohongt

Xiaohongt Mar 8, 2013

Contributor

verified, hub context issue logged in #1660

Contributor

Xiaohongt commented Mar 8, 2013

verified, hub context issue logged in #1660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment