Skip to content

Hub Clients.Client(null).foo() should throw same as PersistentConnection Connection.Send(null, message) #1265

Closed
Xiaohongt opened this Issue Jan 8, 2013 · 4 comments

2 participants

@Xiaohongt
SignalR member

in Hub Clients.Client(null).foo() doesn't throw
in PersistentConnection Connection.Send(null, message) throw

@abnanda1 abnanda1 was assigned Feb 22, 2013
@abnanda1
abnanda1 commented Mar 5, 2013

This issue has already been fixed.

@abnanda1 abnanda1 closed this Mar 5, 2013
@abnanda1 abnanda1 reopened this Mar 6, 2013
@abnanda1 abnanda1 added a commit that referenced this issue Mar 6, 2013
@abnanda1 abnanda1 Added a null check for the Send and Group methods in Hub and Persiste…
…nt Connection

- Added the corresponding unit tests for the null cases

#1265
ccdade4
@Xiaohongt
SignalR member

we should also throw for empty connectionId here

@abnanda1 abnanda1 added a commit that referenced this issue Mar 7, 2013
@abnanda1 abnanda1 Added checks for null and empty values in the Send and Group methods …
…in Hub and Persistent Connection

#1265
1162f91
@abnanda1
abnanda1 commented Mar 7, 2013

I have added the checks for empty values. Please verify.

@chenriks chenriks pushed a commit to chenriks/SignalR that referenced this issue Mar 7, 2013
@abnanda1 abnanda1 Added a null check for the Send and Group methods in Hub and Persiste…
…nt Connection

- Added the corresponding unit tests for the null cases

#1265
8e57ab6
@chenriks chenriks pushed a commit to chenriks/SignalR that referenced this issue Mar 7, 2013
@abnanda1 abnanda1 Added checks for null and empty values in the Send and Group methods …
…in Hub and Persistent Connection

#1265
694e13e
@abnanda1 abnanda1 added a commit that referenced this issue Mar 8, 2013
@abnanda1 abnanda1 Made changes as per code review feedback
- Added the null or empty error message to the Resources file
#1265
53507f3
@abnanda1 abnanda1 added a commit that referenced this issue Mar 8, 2013
@abnanda1 abnanda1 Made changes as per code review feedback
- Added the null or empty error message to the Resources file
#1265
47c7084
@Xiaohongt
SignalR member

verified, hub context issue logged in #1660

@Xiaohongt Xiaohongt closed this Mar 8, 2013
@abnanda1 abnanda1 was unassigned by Xiaohongt Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.