Add overloads for methods with params array on hot paths #1277

Closed
DamianEdwards opened this Issue Jan 10, 2013 · 2 comments

Comments

Projects
None yet
3 participants
Owner

DamianEdwards commented Jan 10, 2013

E.g.

public static class ConnectionExtensions
{
    public static Task Broadcast(this IConnection connection, object value, params string[] exclude);
    public static Task Send(this IConnection connection, string signal, object value, params string[] exclude);
}

davidfowl was assigned Jan 10, 2013

Owner

davidfowl commented Jan 16, 2013

We can't avoid allocations in the places we use params arrays.

davidfowl was assigned Jan 16, 2013

Xiaohongt was assigned Jan 16, 2013

Contributor

Xiaohongt commented Jan 16, 2013

verified the change we can have

Xiaohongt closed this Jan 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment