Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add overloads for methods with params array on hot paths #1277

Closed
DamianEdwards opened this Issue · 2 comments

3 participants

@DamianEdwards

E.g.

public static class ConnectionExtensions
{
    public static Task Broadcast(this IConnection connection, object value, params string[] exclude);
    public static Task Send(this IConnection connection, string signal, object value, params string[] exclude);
}
@davidfowl davidfowl was assigned
@davidfowl
Owner

We can't avoid allocations in the places we use params arrays.

@davidfowl davidfowl was assigned
@Xiaohongt Xiaohongt was assigned
@Xiaohongt
Collaborator

verified the change we can have

@Xiaohongt Xiaohongt closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.