.NET client OnError is raised when calling connection.Stop and using WebSocket transport #1397

Closed
davidfowl opened this Issue Jan 23, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@davidfowl
Member

davidfowl commented Jan 23, 2013

If we're calling stop the OnError event shouldn't be raised.

@ghost ghost assigned davidfowl Feb 13, 2013

davidfowl added a commit that referenced this issue Feb 13, 2013

Don't raise the error event when stopping the connection.
- Never throw an operation cancelled exception from the websocket handler,
  just let it throw normally.
- Added functional test.

#1397

@davidfowl davidfowl reopened this Feb 23, 2013

davidfowl added a commit that referenced this issue Feb 23, 2013

Fix OnError getting called in wrong cases in .NET client.
- Fix other case where disconnect token is tripped and OnError is still called.

#1397
@Xiaohongt

This comment has been minimized.

Show comment
Hide comment
@Xiaohongt

Xiaohongt Feb 26, 2013

Contributor

verified

Contributor

Xiaohongt commented Feb 26, 2013

verified

@Xiaohongt Xiaohongt closed this Feb 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment