Skip to content

Loading…

.NET client OnError is raised when calling connection.Stop and using WebSocket transport #1397

Closed
davidfowl opened this Issue · 2 comments

3 participants

@davidfowl
SignalR member

If we're calling stop the OnError event shouldn't be raised.

@davidfowl davidfowl was assigned
@davidfowl davidfowl added a commit that referenced this issue
@davidfowl davidfowl Don't raise the error event when stopping the connection.
- Never throw an operation cancelled exception from the websocket handler,
  just let it throw normally.
- Added functional test.

#1397
954a2c6
@davidfowl davidfowl reopened this
@davidfowl davidfowl added a commit that referenced this issue
@davidfowl davidfowl Fix OnError getting called in wrong cases in .NET client.
- Fix other case where disconnect token is tripped and OnError is still called.

#1397
b760b07
@Xiaohongt
SignalR member

verified

@Xiaohongt Xiaohongt closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.