Hub method discovery includes methods it shouldn't #1443

Closed
DamianEdwards opened this Issue Jan 29, 2013 · 1 comment

Comments

Projects
None yet
3 participants
Owner

DamianEdwards commented Jan 29, 2013

ReflectionHelper.GetExportedHubMethods allows unintended methods to be called. There are two issues: (a) it uses a blacklist approach instead of a whitelist approach [which forgets about things like events], and (b) it does not account for virtual overrides. Look at MVC’s ActionMethodSelector for inspiration.

davidfowl was assigned Jan 29, 2013

@davidfowl davidfowl added a commit that referenced this issue Jan 29, 2013

@davidfowl davidfowl Don't expose certain methods on hub methods.
- Don't expose methods on object or events.
- Added unit tests.
#1443
97b9adc

@davidfowl davidfowl added a commit that referenced this issue Jan 30, 2013

@davidfowl davidfowl Don't expose certain methods on hub methods.
- Don't expose methods on object or events.
- Added unit tests.
#1443
99be864
Contributor

Xiaohongt commented Jan 31, 2013

verified

Xiaohongt closed this Jan 31, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment