Route matching for the Owin hub dispatcher handler is too agressive #1445

Closed
DamianEdwards opened this Issue Jan 29, 2013 · 2 comments

Projects

None yet

4 participants

@DamianEdwards
SignalR member

The HubDispatcherHandler matches any path that starts with the Hub url prefix (~/signalr by default). It should be explicitly matching as it allows arbitrary urls through to the HubDispatcher with the current code.

@davidfowl davidfowl was assigned Jan 29, 2013
@davidfowl davidfowl added a commit that referenced this issue Jan 30, 2013
@davidfowl davidfowl Match prefixes for routes properly in owin handlers.
- Added functional and unit tests.

#1445
4744ec5
@davidfowl davidfowl added a commit that referenced this issue Jan 30, 2013
@davidfowl davidfowl Match prefixes for routes properly in owin handlers.
- Added functional and unit tests.

#1445
eb8a2ff
@Xiaohongt
SignalR member

verified on owin selfhost

@Xiaohongt Xiaohongt closed this Feb 1, 2013
@DanielBryars

Does the fact this issues is closed mean you have decided to keep the behavior "matches any path that starts with the Hub url prefix (~/signalr by default)"? Or might you reopen this issue?

As per this question on StackOverflow I would like to take a dependency on this behavior :

http://stackoverflow.com/questions/37729176/is-the-current-default-signalr-url-routing-behavior-by-design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment