WebSocket leaks if Close throws an exception #1554

Closed
davidfowl opened this Issue Feb 20, 2013 · 1 comment

Comments

Projects
None yet
2 participants
Owner

davidfowl commented Feb 20, 2013

It's possible that if this line throws:
https://github.com/SignalR/SignalR/blob/master/src/Microsoft.AspNet.SignalR.Owin45/WebSockets/WebSocketHandler.cs#L218

We'll never get rid of the WebSocketTransport types.

davidfowl was assigned Feb 20, 2013

@davidfowl davidfowl added a commit that referenced this issue Feb 20, 2013

@davidfowl davidfowl Always fire OnClose even if Close throws an error.
- Added unit test
#1554
2dd706b
Contributor

Xiaohongt commented Feb 21, 2013

verified

Xiaohongt closed this Feb 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment