Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for overriding JS json deserializing function #1564

Closed
stevozilik opened this issue Feb 21, 2013 · 2 comments
Closed

Allow for overriding JS json deserializing function #1564

stevozilik opened this issue Feb 21, 2013 · 2 comments
Assignees
@Xiaohongt
Labels
type: Feature
Milestone
2.0.0 Beta 1

Comments

@stevozilik
Copy link

Currently signalr.js is hardcoded to use window.JSON.parse function for deserializing messages. The problem is that function is not capable of deserializing javascript dates i.e:

..."ServerTime":new Date(1361310055896)...

the $.connection object could expose a function that would be used for deserializing and by default use the window.JSON.parse, but allowing for overriding to any other deserializing func.

I guess same goes for serialization process, to be consistent.
@ghost ghost assigned DamianEdwards May 1, 2013
DamianEdwards added a commit that referenced this issue May 7, 2013
@DamianEdwards
Support custom json object in JS client
1ce3d1f 
- Added connection.prototype.json which is initialized as window.JSON
- Changed default ajax content type to text
- Added connection._parseRespons helper to parse ajax responses from text to JSON (when it's not JSONP)
- Update all JS client code to use connection._parseResponse
- Added unit & functional tests
- Updated affected tests
- #1564
@DamianEdwards DamianEdwards mentioned this issue May 7, 2013
Closed
DamianEdwards added a commit that referenced this issue May 7, 2013
@DamianEdwards
Support custom json object in JS client
17d9040 
- Added connection.prototype.json which is initialized as window.JSON
- Changed default ajax content type to text
- Added connection._parseRespons helper to parse ajax responses from text to JSON (when it's not JSONP)
- Update all JS client code to use connection._parseResponse
- Added unit & functional tests
- Updated affected tests
- #1564
@ghost ghost assigned Xiaohongt May 7, 2013
@DamianEdwards
Copy link
Member

The JS client connection object now has a "json" property you can set to a custom object with parse and stringify methods. It defaults to window.JSON.

@Xiaohongt
Copy link
Contributor

verified

@NTaylorMullen NTaylorMullen mentioned this issue Oct 22, 2013
Closed
@davelock davelock mentioned this issue Mar 24, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiaohongt Xiaohongt

Labels
type: Feature
Projects
None yet
Milestone
2.0.0 Beta 1
Development

No branches or pull requests
3 participants
@DamianEdwards @stevozilik @Xiaohongt