Skip to content

in HubContext Clients.Client(null).foo() doesn't throw #1660

Closed
Xiaohongt opened this Issue Mar 8, 2013 · 2 comments

2 participants

@Xiaohongt
SignalR member

e.g.

 var hubContext = GlobalHost.ConnectionManager.GetHubContext<MyHub>();

hubContext.Clients.Client(null).foo2("from context Client");
hubContext.Clients.Client("").foo2("from context Client");

hubContext.Clients.Group(null).foo2("from context Group");
hubContext.Clients.Group("").foo2("from context Group");

these should throw, currently these didn't

@abnanda1 abnanda1 was assigned Mar 8, 2013
@abnanda1 abnanda1 added a commit that referenced this issue Mar 9, 2013
@abnanda1 abnanda1 Made changes as per code-review feedback
- Added null and empty checks to Group and Client methods in HubContext
 #1660
93816f0
@abnanda1
abnanda1 commented Mar 9, 2013

I have made the required changes. Please verify.

@Xiaohongt
SignalR member

verified

@Xiaohongt Xiaohongt closed this Mar 11, 2013
@abnanda1 abnanda1 was unassigned by Xiaohongt Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.