Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Overwhelming the queue can cause issues sending to other clients #1847

Closed
gustavo-armenta opened this Issue Apr 10, 2013 · 5 comments

Comments

Projects
None yet
4 participants
Contributor

gustavo-armenta commented Apr 10, 2013

Any functional impact
malicious client sending messages without any delay can cause denial of service

Minimal repro steps
Enable ServiceBus scale out in the samples app
Start N instances (usually 2-4) of the .NET client until the last client is not able to send messages

Expected result
all clients should send messages

Actual result
eventually new clients cannot send messages

@ghost ghost assigned davidfowl Apr 10, 2013

Owner

davidfowl commented Apr 22, 2013

@gustavo-armenta Can you provide your sample code?

Owner

davidfowl commented Apr 22, 2013

I can reproduce with the client sample.

Owner

DamianEdwards commented Apr 23, 2013

We're going to remove the send queue altogether. It will be up to the application developer to handle load on the backplane based on errors it returns or other app/environment-specific logic.

@davidfowl davidfowl added a commit that referenced this issue Apr 26, 2013

@davidfowl davidfowl Added the ability to tweak the queue size.
- Turned the queue off by default.
- Allow setting the queue size in ScaleoutConfiguration.

#1847
281c538
Owner

davidfowl commented Apr 26, 2013

@gustavo-armenta The queue size is now configurable and is 0 (disabled) by default. This doesn't fix the issue as we discussed today but it puts the problem onto the scaleout backplane directly.

@ghost ghost assigned Xiaohongt Apr 28, 2013

Contributor

Xiaohongt commented May 2, 2013

verified

@Xiaohongt Xiaohongt closed this May 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment