I had recently upgraded to version 1.1.0 from beta1. I started to observe that the "remove" method doesn't work as the "client" (web browser) is still receiving messages from the "other" group even if I initiated a "leave". Note that "leaving" the group doesn't mean closing the web browser. It's still in the same page (Single Page Application) and leaving/joining a group is triggered by a selection (combo box for example).
See this SO: http://stackoverflow.com/questions/16572387/signalr-groups-remove-doesnt-work
Also, I uploaded a mock project to reproduce the problem: https://github.com/ericpanorel/SignalrDebugForDfowler
It's a bug that is easier to repro in Long Polling
@ericpanorel I'm reproing this bug on 1.1 beta as well. Are you saying you only started seeing it on 1.1 RTW?
I downloaded the package a few days ago (nuget) with the "-pre" suffix, and that was working still (at least on my application). This was the package:
<package id="Microsoft.AspNet.SignalR.Core" version="1.0.1" targetFramework="net40-Client" />
<package id="Microsoft.AspNet.SignalR.Owin" version="1.0.1" targetFramework="net40-Client" />
<package id="Microsoft.Owin.Host.HttpListener" version="0.21.0-pre" targetFramework="net40-Client" />
<package id="Microsoft.Owin.Hosting" version="0.21.0-pre" targetFramework="net40-Client" />
<package id="Newtonsoft.Json" version="4.5.11" targetFramework="net40-Client" />
<package id="Owin" version="1.0" targetFramework="net40-Client" />
That's 1.0.1 not 1.1.0. That's in line with what I'm seeing. This bug was introduced in 1.1.0 beta not RTW.
Oh I see, my bad I thought the -pre meant beta. Just started playing on these things.
@ericpanorel in general -pre means "allow prerelease". The versions of SignalR.Core in your xml file is 1.0.1 NON prerelease. The version of Microsoft.Owin.Hosting is 0.21.0-pre.
Got it. Reverting to 1.0.1 for now
We're fixing this issue as it's a pretty bad regression. Just FYI.
Cool thanks. I hope I can help in the future as I find this project really exciting
Fixed issues with group token.
- Make sure group token is properly updated on changes
- Made diffset just detect changes in groups.
- Serialize group token even if groups are empty.
- Added tests for the new diffset.
Call AddEventCore from SetEventTopic.
- This will stop overriden methods from running. DefaultSubscription
was incorrectly calling AddEventTopic during SetEventTopic.
Make diffset work better.
- Truly Detect changes and added unit tests
to verify new changes.