Remove dependency on Microsoft.Owin.Security.DataProtection.DpapiDataProtectionProvider #2104

Closed
DamianEdwards opened this Issue May 29, 2013 · 3 comments

Comments

Projects
None yet
4 participants
@DamianEdwards
Member

DamianEdwards commented May 29, 2013

The code in OwinExtensions.cs that attempts to retrieve an IDataProtectionProvider from IAppBuilder and then if that's null create an instance of Microsoft.Owin.Security.DataProtection.DpapiDataProtectionProvider using the default ctor needs to be removed. The parameterless ctor has been obsoleted from Microsoft.Owin.Security.

Instead, SignalR should simply call the GetDataProtector() extension method on IAppBuilder and inject that into the dependency resolver.

@davidfowl

This comment has been minimized.

Show comment
Hide comment
@davidfowl

davidfowl May 30, 2013

Member

It's been obsoleted and isn't even released yet. Epic.

Member

davidfowl commented May 30, 2013

It's been obsoleted and isn't even released yet. Epic.

@ghost ghost assigned halter73 Jun 7, 2013

@halter73

This comment has been minimized.

Show comment
Hide comment
@halter73

halter73 Jun 11, 2013

Member

Should I use CreateDataProtector(this IAppBuilder app, params string[] purposes)? It looks to me that CreateDataProtector cannot return null. Is that the case? What about on Mono?

Member

halter73 commented Jun 11, 2013

Should I use CreateDataProtector(this IAppBuilder app, params string[] purposes)? It looks to me that CreateDataProtector cannot return null. Is that the case? What about on Mono?

@Xiaohongt

This comment has been minimized.

Show comment
Hide comment
@Xiaohongt

Xiaohongt Jun 19, 2013

Contributor

verified

Contributor

Xiaohongt commented Jun 19, 2013

verified

@Xiaohongt Xiaohongt closed this Jun 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment