JS client foreverFrame run into script error when immediately start->stop->start connection #2190

Closed
Xiaohongt opened this Issue Jun 21, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@Xiaohongt
Contributor

Xiaohongt commented Jun 21, 2013

Functional impact:
In JS client use foreverFrame, when immediately start->stop->start on connection, it run into script error:
SCRIPT5007: Object expected
jquery.signalR.js, line 1047 character 17

Note, this is regression.

Repro:
1). use the asp.net sample HubConnectionAPI
2). in HubConnectionAPI.js, update start function as below:

    start = function () {
        $.connection.hub.start({ transport: activeTransport, jsonp: isJsonp })
            .done(function () {
                $("<li/>").html("started transport: " + $.connection.hub.transport.name + " " + $.connection.hub.id)
                            .appendTo(messages);

                stopStartBtn.prop("disabled", false)
                            .find("span")
                                .text("Stop Connection")
                                .end()
                            .find("i")
                                .removeClass("icon-play")
                                .addClass("icon-stop");

            });

        $.connection.hub.stop();
        $.connection.hub.start({ transport: activeTransport });
   };

3). request HubConnectionAPI/Default.aspx?transport=foreverFrame on IE

Expected result:
no script error

Actual result:
script error:
SCRIPT5007: Object expected
jquery.signalR.js, line 1047 character 17

@NTaylorMullen

This comment has been minimized.

Show comment Hide comment
@NTaylorMullen

NTaylorMullen Jun 21, 2013

Contributor

This is fixed by #2181

Contributor

NTaylorMullen commented Jun 21, 2013

This is fixed by #2181

@Xiaohongt

This comment has been minimized.

Show comment Hide comment
@Xiaohongt

Xiaohongt Jun 23, 2013

Contributor

verified

Contributor

Xiaohongt commented Jun 23, 2013

verified

@Xiaohongt Xiaohongt closed this Jun 23, 2013

NTaylorMullen added a commit that referenced this issue Oct 2, 2013

Added test to verify hub event handlers are only triggered once per b…
…inding.

- This is a multi-purpose test to verify 3 bugs.

#2187
#2160
#2190

NTaylorMullen added a commit that referenced this issue Oct 2, 2013

Added test to verify hub event handlers are only triggered once per b…
…inding.

- This is a multi-purpose test to verify 3 bugs.

#2187
#2160
#2190

NTaylorMullen added a commit that referenced this issue Oct 7, 2013

Added test to verify hub event handlers are only triggered once per b…
…inding.

- This is a multi-purpose test to verify 3 bugs.

#2187
#2160
#2190

NTaylorMullen added a commit that referenced this issue Oct 7, 2013

Added test to verify hub event handlers are only triggered once per b…
…inding.

- This is a multi-purpose test to verify 3 bugs.

#2187
#2160
#2190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment