JS Client OnError should be invoked with non-empty error messages #2317

gustavo-armenta opened this Issue Jul 20, 2013 · 2 comments


None yet

3 participants


Function "onFailed" is called when failing on connection._parseResponse(result);
The problem is "error" does not have a member "responseText", it has members "description", "message", "number", "stack". Right now, it results on invoking onError event with an empty string. We should check all paths triggering onError and validate we are sending a correct error member

                onFailed = function (error, connection) {
                    $(connection).triggerHandler(events.onError, [error.responseText]);
                    deferred.reject("SignalR: Error during negotiation request: " + error.responseText);
                    // Stop the connection if negotiate failed
SignalR member

I totally agree.

@DamianEdwards DamianEdwards added a commit that referenced this issue Jul 25, 2013
@DamianEdwards DamianEdwards Review feedback d225701

tested after #2345, error is never empty and contains error.message and error.source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment